[Batch] My own general inability

~ED~

Think I will just make this my help me solve this problem thread.

----


Something is wrong with this.

SOLVED:

Spoiler

It is meant to:
Set DISM location, check if it exist and if so make folders and goto :getadmin.

OR

Set DISM location, check if it exist and if NOT- ask for its location, check if it exist reset DISM location to where it was supplied by user then goto get admin.

For some reason it jumps from where the user sets the location to another place in the batch file.

Code:

:DISMCheck
:: Checks for DISM
SET DISM=C:\Windows\System32\DISM.EXE

IF EXIST !DISM! (
    :: Creates WorkDir and subfolders.
    IF NOT EXIST "WorkDir" MD WorkDir & MD WorkDir\Mount & MD WorkDir\Images & MD WorkDir\ISO
    GOTO :GetAdmin
) ELSE (
:: DISM wasn't found.
ECHO.
ECHO. Couldn't locate DISM.exe at C:\Windows\System32\Dism.exe
ECHO.
SET /P altdism=Drag and drop Dism.exe here:
IF EXIST "!altdism!" (
    DISM=!altdism! 
    PAUSE
    GOTO :GetAdmin
) ELSE (
CLS&GOTO :DISMCheck
)
)

 

It was so simple.

 

When running DISM /Get-CurrentEdition you get something like the following.

Code:

C:\Windows\system32>DISM /image:%mountdir% /Get-CurrentEdition

Deployment Image Servicing and Management tool
Version: 6.1.7600.16385


Current Edition: Home Basic

The command completed successfully. 

C:\Windows\system32>

I need to capture the "Home Basic" (and any other edition that may appear here mounted) to a variable.
Also need to capture the 6.1.7600.16385 to a variable but once I see how its done I can do that.

I had this working:

Code:

FOR /F "tokens=4 delims=:" %%A in ('!DISM! /image:!mountdir! /Get-CurrentEdition') do set currentedition=%%A
ECHO.Ver output: !VER!

But it stopped working on the other editions, ex: ultimate, core, etc.

 

Works. Thanks s1ave77. Once I get this a little bit further completed I will post. Till then


Well the way I had in mind of doing it would have needed to use dism twice which is a time killer.

Look for either a simple way of adding onto

Code:

FOR /F "tokens=2 delims=: " %%A in ('%DISM% /image:%mountdir% /Get-CurrentEdition ^| findstr /i "Version"') do echo %%A

for it to get current edition and version.

 

What is this from as Id like the full script.

 

Okay, think maybe it is time I posted the full script for when I get assistance now.

Spoiler

Code:

@echo off
setlocal ENABLEDELAYEDEXPANSION
TITLE Humphrey's %~nx0
CD /D %~dp0
IF NOT EXIST "WorkDir" MD WorkDir & MD WorkDir\Mount & MD WorkDir\Images & MD WorkDir\ISO
SET inputfile=%1%
SET WorkDir=.\WorkDir
SET MountDir=!WorkDir!\Mount
SET ISO=!WorkDir!\ISO
SET Images=!WorkDir!\Images
IF "%~1"=="" GOTO :Check
IF "%~n1"=="WorkDir" GOTO :Credit
:Check
IF /i not "%~x1"==".wim" (
    CLS 
    TITLE How to use %~nx0
    ECHO.
    ECHO. ===============================================
    ECHO.                  Instructions
    ECHO. ===============================================
    ECHO.
    ECHO. %~nx0 is meant for modifiying WIM files and must 
    ECHO. have a .WIM file dropped onto it.  
    ECHO.
    ECHO. Drag and drop an Install.wim onto %~nx0.
    ECHO.
    ECHO.
    ECHO. File: !inputfile! is NOT a WIM file. 
    ECHO. Drop one onto %~nx0 to proceed. 
    PAUSE >NUL&EXIT
) ELSE (
    GOTO :DISMCheck
)
:DISMCheck
:: Checks for DISM
IF "!PROCESSOR_ARCHITECTURE!"=="AMD64" (SET _ProF=!ProgramFiles^(x86^)!) ELSE (    SET _ProF=!ProgramFiles!)
SET DISM="!_ProF!\Windows Kits\8.1\Assessment and Deployment Kit\Deployment Tools\!PROCESSOR_ARCHITECTURE!\DISM\DISM.EXE"
IF EXIST !DISM! (
    :: DISM found.
    GOTO :GetAdmin
) ELSE (
:: DISM wasn't found.
ECHO.
ECHO. Couldn't locate DISM.exe at C:\Windows\System32\Dism.exe
ECHO.
SET /P altdism=Drag and drop Dism.exe here: 
IF EXIST "!altdism!" (
    SET DISM=!altdism! 
    GOTO :GetAdmin
) ELSE (
CLS&GOTO :DISMCheck
)
)

:GetAdmin
:: Request administrative permission.
@(NET FILE||(powershell -command Start-Process '%0' -Verb runAs -ArgumentList '%* '&EXIT /B))>NUL 2>&1

:: Get DISM version
ECHO.
ECHO. DISM Location: !DISM!
FOR /F "tokens=2 delims=: " %%A in ('!DISM! /? ^| findstr /i "Version"') do SET _dVer=%%A

:CommandCenter
ECHO.
ECHO. Dism Version: !_dVer!
ECHO. ===============================================
ECHO.                  DISM Commands
ECHO. ===============================================
ECHO. !currentedition!
ECHO.
ECHO. [0] Mount %~nx1    [1] Unmount !MountDir!
ECHO. [2] Get %~nx1 info [3] Get !MountDir! info
ECHO. [4] Change Language      [5]
ECHO.
choice /C 0123456789 /N /M "Select menu item:"
if !ERRORLEVEL! EQU 1 CLS & GOTO :Mount
if !ERRORLEVEL! EQU 2 CLS & GOTO :UnMount
if !ERRORLEVEL! EQU 3 CLS & GOTO 

:Mount
!DISM! /Get-ImageInfo /ImageFile:!inputfile!
ECHO.
SET /P Index= Which index?: 
CLS
!DISM! /Mount-wim /wimfile:!inputfile! /Index:!INDEX! /Mountdir:!MountDir! 
ECHO.
ECHO. Gathering some info.
For /F "Tokens=1,2* Delims=: " %%A In (
    '"!DISM!" /Image:!mountdir! /Get-CurrentEdition') Do (
    If %%A Equ Version Set VER=%%B
    If %%B Equ Edition Set currentedition=%%C
    )
GOTO :CommandCenter    
:UnMount
ECHO.
choice /C YN /N /M " Save to %~nx1 ?: "
if !ERRORLEVEL! EQU 1 SET SAVE=/Commit
if !ERRORLEVEL! EQU 2 SET SAVE=/Discard
!DISM! /UNMount-wim /Mountdir:!MountDir! !SAVE!
GOTO :CommandCenter    

:SelfCheck
ECHO.
ECHO. ===============================================
ECHO.                 Self Diagnosis
ECHO. ===============================================
ECHO.
ECHO. DISM.exe: !DISM!
ECHO. Input file: !inputfile!
ECHO. Work Dir: !WorkDir!
ECHO. Mount Dir:!MountDir!
ECHO. ISO: !ISO!
ECHO. Images: !Images!
ECHO.
PAUSE &GOTO :EOF
:Credit
:: People that assisted in the creation of this batch file.
TITLE Credit is due.
ECHO. ===============================================
ECHO.               Special Thanks To
ECHO. ===============================================
ECHO.
ECHO. BetonMAN - Amazing admin prompt.
ECHO.
ECHO. Compo - General scripting assistance.
ECHO.
ECHO. s1ave77 - General scripting assistance.
ECHO.
PAUSE >NUL & GOTO :EOF
:EOF
exit /b

In BLUE I am having issue with it grabbing the wrong version. I've played with it a bit and cannot seem to figure it out.
When running the command, you get two "Version"'s, the first one being the DISM version and the second is the IMAGE version.


In RED I am getting 'C:\Program' for its variable output. Other instances of !DISM! function correctly afaik so I am not sure what is wrong here.


I see pretty much the same code in blue that is in red, think I will adapt red to be like blue and see if that works. Sort of worked but not.

@s1ave77: Looked at the batch files in jack of all trades or w/e and DAMN. So many lines of code.

 

When using your line, this is what I get.

Code:

'C:\Program' is not recognized as an internal or external command, operable program or batch file.

 Dism Version:
 ===============================================
                  DISM Commands
 ===============================================

 [0] Mount install.wim    [1] Unmount .\WorkDir\Mount
 [2] Get install.wim info [3] Get .\WorkDir\Mount info
 [4] Change Language      [5]

Select menu item:

Here is the command I would prefer to run seeing as it is meant to get the DISM version, it shouldn't run a DISM command other then help so that it isn't slower then what is required of it. (fyi, I get the same program if I run it as %DISM% /image:%mountdir% /Get-CurrentEdition)

Code:

ECHO.
ECHO.%DISM%
ECHO.
FOR /F "tokens=2 delims=: " %%A in ('%DISM% /? ^| findstr /i "Version"') do set _dVer=%%A

My echo.%dism% = "C:\Program Files (x86)\Windows Kits\8.1\Assessment and Deployment Kit\Deployment Tools\AMD64\DISM\DISM.EXE"

I think it has something to do with how !DISM! is being set or passed along. I used your line of code on its own in cmd prompt and it functions..

Code:

C:\Program Files (x86)\Windows Kits\8.1\Assessment and Deployment Kit\Deployment Tools>
FOR /F "tokens=2 delims=: " %A in ('DISM /? ^| findstr /i "Version"') doset _dVer=%A

C:\Program Files (x86)\Windows Kits\8.1\Assessment and Deployment Kit\Deployment Tools>
set _dVer=6.3.9600.17029

 

Same results other then it force closes the batch.

and with using that SET layout, %DISM% causes force close unless wrapped in quotes, if changed to !DISM! it doesn't force close.

Either way, both produce the same output

Code:

'C:\Program' is not recognized as an internal or external command,operable program or batch file.

Just fyi, if you attempt to use the batch file to see it run threw its paces then you must drop a install.wim onto the batchs icon on the desktop- or code into the batch around that.

 

Force closes

Code:

IF "%PROCESSOR_ARCHITECTURE%"=="AMD64" (SET _ProF=%%ProgramFiles(x86)%%) ELSE (SET _ProF=%%ProgramFiles%%)

Had to escape the (x86)

!DISM! = %ProgramFiles(x86)%\Windows Kits\8.1\Assessment and Deployment Kit\Deployment Tools\AMD64\DISM\DISM.EXE

Code:

IF "%PROCESSOR_ARCHITECTURE%"=="AMD64" (SET _ProF=%%ProgramFiles^(x86^)%%) ELSE (SET _ProF=%%ProgramFiles%%)

Output = 'C:\Program' is not recognized as an internal or external command, operable program or batch file.


!DISM! = C:\Program Files (x86)\Windows Kits\8.1\Assessment and Deployment Kit\Deployment Tools\AMD64\DISM\DISM.EXE

Code:

IF "%PROCESSOR_ARCHITECTURE%"=="AMD64" (SET _ProF=!!ProgramFiles^(x86^)!!) ELSE (SET _ProF=!!ProgramFiles!!)

Output = 'C:\Program' is not recognized as an internal or external command, operable program or batch file.

 

So after playing around for a bit I think I linked the issue to the

Code:

FOR /F "tokens=2 delims=: " %%A in ('%DISM% /? ^| findstr /i "Version"') do set _dVer=%%A

findstr here. without that line everything seems to work better.
For now I will comment that out and continue with the rest of it.