Hey! I'm sorry to inform you that I found a bug.. During my tests for my Win10 dvd I first used the version from the 7th of August and, on my Asus 1001PXD netbook, it worked fine. Now I updated it to the final version from 19th of August and it applied the ATComputers theme instead of the ASUS one.. I extracted the Install.cmd from this project and made some tests on my netbook by using the same commands, and I discovered that, in the last version, after the codes for checking the brand, %MAN% was equal to ATCOMP. By using the commands from the version of the 7th of August, %MAN% was equal to ASUS. If you need some information to fix this bug just ask . By the way, on VMWare player everything is working fine. EDIT: I made more tests and it seems that the bug is caused by the "IF /I NOT "%MAN%"=="DEFAULT" " from this codes: Code: IF EXIST %OEMS% for /f "tokens=1,2,3 delims=|" %%a in ('type %OEMS% ^| findstr /I "\<%%INFO%%\>" ^| findstr /I "\<%%CSNAME%%"') do (set MAN=%%c) IF /I NOT "%MAN%"=="DEFAULT" echo %DATE% %TIME% Defined %MAN% manufacture found. >>"%SystemDrive%\Log\Project.log"&goto :SETKEY for every variable (csname, csvendor, etc). By echoing everything, the code sets %MAN% = ASUS before the condition IF, then after the condition it sets %MAN% = ATCOMP (which is on the next line in oemscan.ini). If I delete it and set everything in the same line like this Code: IF EXIST %OEMS% for /f "tokens=1,2,3 delims=|" %%a in ('type %OEMS% ^| findstr /I "\<%%INFO%%\>" ^| findstr /I "\<%%CSNAME%%"') do (set MAN=%%c&echo %DATE% %TIME% Defined %MAN% manufacture found. >>"%SystemDrive%\Log\Project.log"&goto :SETKEY it works.. EDIT2: I discovered that this bug only happens on my netbook. If i run the same exact code with the condition IF on my desktop PC which has also an ASUS motherboard, it works fine by setting %MAN%=ASUS. The only difference is that in my desktop, %CSVENDOR% equals to just "ASUS", in my netbook %CSVENDOR% equals to "ASUSTek Computer INC.". EDIT3: Yea I know, I talk too much. Anyway is not the condition IF that causes the bug.. it happens before it. I think it's my pc fault because it has the word "computer" inside %CSVENDOR% (ASUSTek Computer INC.) so it sets first %MAN% = ASUS, then it checks for "Computer" inside oemscan.ini and it finds it in "ATComputers" so it sets %MAN% = ATCOMP. If I write the code in the same line and cancel the condition IF, it skips to the next section (SETKEY) before checking the rest of the oemscan.ini.
Post query tool results.txt file and Project.txt. I have tested with set variables and it works like it should. Got a feeling it might be a query not listed. If you used your edited version and going to post the Project.txt file, dont bother because it will do no good. Would have been better you telling me this before all your editing so I could see the real problem. We can still look at the query tool results.txt file, unless you edited that also. lol I could have saved you time and effort in the long run. There was a reason back on the other page I changed that logging routine for MAN. Maybe you should read it. Guess there is no since in having log files if no one posts them.
I edited only the OOBE.cmd, I extracted Install.cmd just to find out why was doing that . Anyway I attach here the log files like you asked (I just deleted from results.txt the installed key of Windows ). I took the project.txt from a clean install of W10 with the last version of the project without touching it. Query Tool works fine, it detect ASUS, but the project applies again ATCOMP.
The question you should be asking yourself since you like to script is WHY is the project seeing ATcomputer instead of ASUS? It doesnt only find the query from the first one but uses all until a match is found. There is a conflict which needs to be addressed. This is WHY the first three queries fail (not included in ini file).... #1 CSPRODUCT NAME - 1001PXD #2 COMPUTERSYSTEM MODEL - 1001PXD #3 BASEBOARD PRODUCT - 1001PXD #8 BIOS ID - BIOS But should get the needed info from query #4. Also did you edit the BIOS query? It only says BIOS in the results.txt file. Is this the normal query output or did you also edit this as well? Never seen a oem bios query say BIOS before on any machine. See, CR should have kicked in but didnt since no bios query matched. This is another problem but I need you to answer my questions in detail please. Your BIOS ID should be _ASUS_ but yours says BIOS. Either edited out or possible bios mod that didnt have correct info in it. This is confusing but this is where your problem is. Its not a script problem but query not matching. The reason loggging wont work like you have it above is because it is encapsulated thus the MAN doesnt get applied until after encapsulation which means in log file you MAN will be DEFAULT instead of OEM MAN. That is why the check is done after the encapsulation. Come on man, keep up. lol Conclusion: If it worked on your other ASUS but not this one then it is a query issue where it isnt listed correctly. No info for BIOS matching either so you have two issues really and none are related to the script (editing that is sloppy). This is why CR did not kick in correctly. It also looks like you edited something in the install.cmd that broke the script from finishing right after the hosts file block enabled. Obviously you edited more then you mentioned. We are done here because I cant troubleshoot if not the original code! You are only breaking it like most do when they get curious. I wish you luck.
Word of advise to all that get curious and break the cmd file and want to complain....NO SUPPORT WILL BE GIVEN!
Seems he did more editing then he wants to admit and it looks like he broke the script. Not my problem. The problem he is having isnt really in script but another area, he can figure that out on his own. I will say this... It is rude to take apart someone else project and edit how you wish then complain it doesnt work after your editing. If there was a problem you should have just got a hold of me and it would have been fix, if it really does need it. It is like a slap in my face when you only post "your" solution (which isnt correct) then tell me to edit it with your fix. I think I am smart enough to troubleshoot and find the correct working solution, dont you? I am not mad at all but it was rude. Prediction: I expect him to include missing info but that too will break it for other oem's, watch. lol
Emh.. I hate to repeat myself but, like I said in my last post: I NEVER touched Query Tool, I NEVER touched my bios, and to get that log I didn't touch your project. The first time the bug showed up I only modified the OOBE.CMD for adding the KMSPico and that's it. The second time I used your project exactly as you updated it and then I got the log file which I posted here. So, what are you accusing me of? Reporting a bug of your project? Well then sorry, you're perfect and my pc sucks, but you really need to accept that your project doesn't work on it instead of trying to put the responsibility on me. I'll repeat one more time: I extracted the install.cmd just to try to understand the cause of the bug. I NEVER modified it before the bug happened. Anyway, just do what you want, it is your project and you can keep it as it is: bugged.
Its not a bug but your included motherboard info isnt included thus why you had NO Bios ID matching. As far as it picking the wrong MAN for branding I cant reproduce that. I have been trying but cant. This leads me back to the ini file again. If you are wanting to correct it then do it the right way instead of breaking it for other oems. I have never seen a Bios ID output that is BIOS. I have even checked Asus site for all their bios id's and none match what shows in the query tool results.txt file. Seems something isnt right on your end more then in the project. I have been researching this on my own without any success on your specific issue. Lets break down the one line you are editing... The first three queries will return with no value for that query match. The other two should get seen (cant reproduce your issue) for branding. If you move the output for log file that has nothing to do with the query being set to MAN! All this does is make the log file show as DEFAULT because the code is encapsulated. It has to be out of the encapsulation so MAN value is set then can output to log file correctly. There is no value in ini file so this and the next two queries fail. There is a conflict because bios info doesnt match with ini file entries. I have no idea how it is seeing ATcomputer as MAN because there is nothing similar in the ini file to cause conflict. Why not just answer the questions instead of arguing with me. Is this a modded system? Did you edit anything other then serial out of the log files? Is the BIOS ID really outputting to say BIOS? There is no way for me to know every variable in every motherboard. Without needed info there isnt much I can do to support it. Do you understand?
In vmware I set all queries to be the same as in your results.txt file and branding is done by query #4 which is ASUS so I cant reproduce your specific issue with the given information. Forced variables set...
I went ahead and added bios id to project and also moved the logging to after set MAN if found to reduce duplicate lines of code plus "if" logging was causing the issue (I cant reproduce) then this will also address it. I want to test with his set variables first before posting to make sure everything works like it should. I am not worried about branding but as a second measure I added the bios id also since no other oem manufacturer included in the project has that same bios id. This should cover this issue completely. Will report back when testing is completed on my end. Three checks done now... 1-MAN 2-MAN2 3-CR I will update the query tool as well when I finish testing. If this doesnt cover the issue then I dont know what else to say or do on the matter. lol
First post updated 08-24-2015. From my own testing with set variables it will brand using #4 query and activate if possible for #8 which should cover both bases and also be checked by CR. Hope this corrects the ASUS issue.
I've been arguing with you because you couldn't believe that I didn't edit anything until another user came in and said that on his system the bios version was also BIOS.. I said that I haven't modified anything in the script, in the first post I was just trying to make myself useful. Now I know that my help isn't appreciated.. Next time I wil only say "on my system doesn't work, here's the log files" and I will not try to do anything at all. I never wanted to insult your project. But then you came in and instead of accepting it you were like "not my problem, your fault". Clearly if the log project.txt is not as you expect something went wrong and like you said it crashed, but the first thing you said was that I changed something in the code instead of trying to understand why, even if I said that I didn't touched anything.. That's it. I just wanted to make clear why I answered like that. Thanks for the new version. I'll try it as soon as possible and tell you if it's working on my pc
I asked specific questions that took you three post to get around to answering and even then it wasnt complete. I did the best I could with what I had to work with. I cannot reproduce the issue myself like I have said in earlier posts. I did what I could to address it for you. Test and let me know. I dont want to include the first three queries into the ini file because those would cause a big conflict.
I tried with the last version and it applied the asus theme correctly, here I post the log files from both query tool and project.txt. The second one again finishes right after hosts file and again, I haven't modified anything. I also noticed that in Windows\setup\scripts there are Install.cmd and oemscan.ini, so it didn't cleanup. I don't know why it crashes, but that's the situation. At least now it applies the correct theme.
Let me ask you this... Does this exist in Pro N version (show hidden and system files)? %SYSTEMDRIVE%\ProgramData\Microsoft\Diagnosis If so then does this exist (you will need to take ownership to view this file)? %SYSTEMDRIVE%\ProgramData\Microsoft\Diagnosis\ETLLogs\AutoLogger\AutoLogger-Diagtrack-Listener.etl I have a strange feeling that this isnt in that version of windows 10. Let me know the full path if anything is there like above.