For which OS are you testing the Toolkit, here for Windows 10 it's working properly Code: =============================================================================== MSMG ToolKit - Apply Tweaks =============================================================================== ------------------------------------------------------------------------------- ####Starting Applying Tweaks################################################### ------------------------------------------------------------------------------- Image : Install.wim Image Index : 2 Image Architecture : x86 Image Version : 10.0.19041.1.0 ------------------------------------------------------------------------------- ####Applying All Tweaks######################################################## ------------------------------------------------------------------------------- ===========================[Install.wim, Index : 2]============================ Mounting Image Registry... Importing Registry Settings to Image Registry... Un-Mounting Image Registry... ------------------------------------------------------------------------------- ####Finished Applying Tweaks################################################### ------------------------------------------------------------------------------- =============================================================================== Press any key to continue . . .
Thanks made the changes and the order of last part is correct, first we need the get the architecture and then do check if it's x64. We can further reduce the code if we set the IndexNo used to get first index number in the selected list of the indexes. Code: :: Getting Install Image Index Architecture call :GetImageArchitecture "%InstallWim%", %IndexNo% >nul
I am also working on windows 10 there was that error i mentioned above in the first release but now everything is okay with fixed release thank you
@sergey130270 Could you please publish a short "How to" about your New_icons pack: correct folder location for placing files, correspondent Toolkit option to integrate? Should this be done with the Toolkit's option via Custom files integration? Does this break SFC or not (LTSC)?
The feature to add new icons is already added for next release. Code: =============================================================================== MSMG ToolKit - Integrate Windows Icons Skin =============================================================================== ------------------------------------------------------------------------------- ####Starting Integrating Windows Icons Skin#################################### ------------------------------------------------------------------------------- Image : Install.wim Image Index : 1 Image Architecture : x64 Image Version : 10.0.19043.1052.0 ------------------------------------------------------------------------------- ####Integrating Windows Windows Icons Skin##################################### ------------------------------------------------------------------------------- ===========================[Install.wim, Index : 1]============================ Copying Windows Icons files to Temporary Folder... Applying Windows Icons Skin to [imageres.dll.mun] file... Applying Windows Icons Skin to [imagesp1.dll.mun] file... Applying Windows Icons Skin to [shell32.dll.mun] file... Applying Windows Icons Skin to [zipfldr.dll.mun] file... Copying Patched Windows Icons files... ------------------------------------------------------------------------------- ####Finished Integrating Windows Icons Skin#################################### ------------------------------------------------------------------------------- =============================================================================== Press any key to continue . . . Edit: It's available now, check the Toolkit.cmd and <Packs\Skins\Icons> at download link.
About the packageindex variable: There is no PackageIndex= set to arm. Only for arm64 in win32calc session which has the value "PackageIndex=3" for arm64 Having said that, that's why I had put an arm with the value "PackageIndex=4" I had placed it in the order below for easy viewing. Code: if "%ImageArchitecture%" equ "arm64" ( set "PackageIndex=3" set "PackageArchitecture=arm64" ) if "%ImageArchitecture%" equ "arm" ( set "PackageIndex=4" set "PackageArchitecture=arm" ) The fact is that I put the value for arm, just to make it ready, because at the moment there is no use.
The arm is already there for Windows 8.1 ARM images and the order should be 3 for ARM and 4 for ARM64 but again right now for both the architecture there's no pack made, so it's left out.
Will this not interfere with the win32calc pack? other one: After the else there is a condition that is not necessary, but it doesn't do any harm either. from Code: if "%SelectedSourceOS%" equ "w10" ( if exist "%DVD%\sources\sxs\*.cab" ( if "%ImageBuild%" leq "16299" set "NetFX35=%DVD%\sources\sxs\microsoft-windows-netfx3-ondemand-package.cab" if "%ImageBuild%" geq "17134" set "NetFX35=%DVD%\sources\sxs\microsoft-windows-netfx3-ondemand-package~31bf3856ad364e35~%PackageArchitecture%~~.cab" ) else ( if "%SelectedSourceOS%" equ "w10" set "NetFX35=%NetFX35%\%SelectedSourceOS%\%PackageVersion%\Microsoft-Windows-NetFx3-OnDemand-Package~31bf3856ad364e35~%PackageArchitecture%~~%PackageVersion%.%PackageServicePackBuild%.cab" ) ) to Code: if "%SelectedSourceOS%" equ "w10" ( if exist "%DVD%\sources\sxs\*.cab" ( if "%ImageBuild%" leq "16299" set "NetFX35=%DVD%\sources\sxs\microsoft-windows-netfx3-ondemand-package.cab" if "%ImageBuild%" geq "17134" set "NetFX35=%DVD%\sources\sxs\microsoft-windows-netfx3-ondemand-package~31bf3856ad364e35~%PackageArchitecture%~~.cab" ) else ( set "NetFX35=%NetFX35%\%SelectedSourceOS%\%PackageVersion%\Microsoft-Windows-NetFx3-OnDemand-Package~31bf3856ad364e35~%PackageArchitecture%~~%PackageVersion%.%PackageServicePackBuild%.cab" ) ) if exist "%DVD%\sources\EI.CFG" del /f /q "%DVD%\sources\EI.cfg" >nul could be call :RemoveFile "%DVD%\sources\EI.cfg" >nul Taking advantage of the function :RemoveFile already checks if the file exists or not. But also, you wouldn't even need this line since >"%DVD%\sources\EI.cfg" will create the file if it doesn't exist and overwrite the contents of the file if it does exist.
Another possible optimization: from: Code: if "%SelectedSourceOS%" equ "w10" ( if "%ImageBuild%" equ "14393" set "NetFX48Pkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~~10.0.14393.0.cab" if "%ImageBuild%" equ "14393" set "NetFX48LpPkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~%ImageDefaultLanguage%~10.0.14393.0.cab" if "%ImageBuild%" equ "15063" set "NetFX48Pkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~~10.0.14393.0.cab" if "%ImageBuild%" equ "15063" set "NetFX48LpPkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~%ImageDefaultLanguage%~10.0.14393.0.cab" if "%ImageBuild%" equ "16299" set "NetFX48Pkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~~10.0.16299.15.cab" if "%ImageBuild%" equ "16299" set "NetFX48LpPkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~%ImageDefaultLanguage%~10.0.16299.15.cab" if "%ImageBuild%" equ "17134" set "NetFX48Pkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~~10.0.16299.15.cab" if "%ImageBuild%" equ "17134" set "NetFX48LpPkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~%ImageDefaultLanguage%~10.0.16299.15.cab" if "%ImageBuild%" equ "17763" set "NetFX48Pkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~~10.0.16299.15.cab" if "%ImageBuild%" equ "17763" set "NetFX48LpPkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~%ImageDefaultLanguage%~10.0.16299.15.cab" ) to Code: if "%SelectedSourceOS%" equ "w10" ( if "%ImageBuild%" geq "14393" if "%ImageBuild%" leq "17763" ( set "NetFX48Pkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~~%PackageVersion%.%PackageServicePackBuild%.cab" set "NetFX48LpPkg=Microsoft-Windows-NetFX48-Package~31bf3856ad364e35~%PackageArchitecture%~%ImageDefaultLanguage%~%PackageVersion%.%PackageServicePackBuild%.cab" ) )
@RaiyvaN , @MSMG I can suggest .NET 4.8 cab (by @abbodi1406) from main OP for LTSC is not compatible with MSMG Toolkit just because of unsuitable filename (Windows10.0-KB4486153-x64.cab)? Not because of file content? Or it depends on cab for Toolkit vs DISM method? I have made a noticement for myself (about this OP & MSMG Toolkit): • MSU .................................... OK • CAB (by MSMG repo) ......... OK • CAB (by M$ catalog) ........... OK • CAB (by @abbodi1406) ...... NOT COMPATIBLE!
Apologies for my misunderstanding - thought you wanted me to try Win32Calculator with and without cleanup to see which worked. I now know that you just wanted SFC log results to compare. Just for the sake of comparison, tried with and without clean up of image folder. Both ISOs with and without cleanup of image folder (5 > 2 > Y/N) produces no errors when running SFC /SCANNOW, however some errors show in the CBS logs which I have attached. CBS 1 is 5 > 2 > Y test image CBS 2 is 5 > 2 > N test image